⚠️ No Changeset found

Latest commit: d1ca3d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CC @sachasayan

@zhangtony239 I think padding is useful to give the content some room to breathe on larger widths. Let's try some variation of p-3.5 sm:p-10 — does that sound about right for you?

@zhangtony239 I think padding is useful to give the content some room to breathe on larger widths. Let's try some variation of p-3.5 sm:p-10 — does that sound about right for you?

Indeed, it's time to add a condition to this CSS.

@sachasayan How about this?

@zhangtony239 Love it. Let's ship this, but one minor nitpick:

Instead of: max-[370px]:p-3.5 p-10

Can you use: p-3.5 min-[370px]:p-10

Keeping responsible styles consistently bottom up means conflicts / bugs later if they occur and we get to build defaults to the narrow sizes. 😇

Sorry to nitpick, and this is a great catch! Thanks for the contribution! 👍

@cte @mrubens Ready to ship once p-3.5 min-[370px]:p-10 is in. 🚀

p-3.5 min-[370px]:p-10

I just noticed that this makes the p-10 take priority over the pt-5 for the top padding - is that intentional?

Maybe we should just merge this as is

@mrubens Let me check it out real quick.

@mrubens It's fine as-is. Very little difference. I'll do another pass on this soon. I think you can just merge. :)